-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Io gripper controller #1439
base: master
Are you sure you want to change the base?
Adding Io gripper controller #1439
Conversation
This PR depends on this PR |
io_gripper_controller/README.md
Outdated
# IO Gripper Controller | ||
|
||
The IO Gripper Controller is provides implementation to control the gripper using IOs. It provides functionalities like open, close and reconfigure which can be used either though action server or service server and also publishes `joint_states` of gripper and also `dynamic_interfaces` for all command and state interfaces. | ||
|
||
## Description of controller's interfaces | ||
|
||
- `joint_states` [`sensor_msgs::msg::JointState`]: Publishes the state of gripper joint and configuration joint | ||
- `dynamic_interfaces` [`control_msgs::msg::DynamicInterfaceValues`]: Publishes all command and state interface of the IOs and sensors of gripper. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should go into the doc folder in the rst format. For an example please check the joint_trajectory_controller
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also write docs extensively about the internal state machine and also internal functionalities and external interface. As template, use the docs from another controller and adjust the content.
io_gripper_controller/include/io_gripper_controller/io_gripper_controller.hpp
Outdated
Show resolved
Hide resolved
io_gripper_controller/include/io_gripper_controller/io_gripper_controller.hpp
Outdated
Show resolved
Hide resolved
io_gripper_controller/include/io_gripper_controller/io_gripper_controller.hpp
Outdated
Show resolved
Hide resolved
io_gripper_controller/include/io_gripper_controller/io_gripper_controller.hpp
Outdated
Show resolved
Hide resolved
io_gripper_controller/include/io_gripper_controller/visibility_control.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First set of comments. The second one comes tomorrow.
io_gripper_controller/README.md
Outdated
# IO Gripper Controller | ||
|
||
The IO Gripper Controller is provides implementation to control the gripper using IOs. It provides functionalities like open, close and reconfigure which can be used either though action server or service server and also publishes `joint_states` of gripper and also `dynamic_interfaces` for all command and state interfaces. | ||
|
||
## Description of controller's interfaces | ||
|
||
- `joint_states` [`sensor_msgs::msg::JointState`]: Publishes the state of gripper joint and configuration joint | ||
- `dynamic_interfaces` [`control_msgs::msg::DynamicInterfaceValues`]: Publishes all command and state interface of the IOs and sensors of gripper. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also write docs extensively about the internal state machine and also internal functionalities and external interface. As template, use the docs from another controller and adjust the content.
io_gripper_controller/include/io_gripper_controller/io_gripper_controller.hpp
Outdated
Show resolved
Hide resolved
io_gripper_controller/include/io_gripper_controller/io_gripper_controller.hpp
Outdated
Show resolved
Hide resolved
- removed the template from license - added one variable per line - documented the enums - updated the doc folder as per `joint_trajectory_controller`
Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
- renamed service_buffer_ to gripper_service_buffer_
This Pull Request introduces the IO Gripper Controller, an implementation for controlling a gripper using IOs. The controller supports functionalities such as open, close, and reconfigure, which can be triggered either through an Action Server or a Service Server. Additionally, the controller publishes the gripper’s state via joint_states and provides dynamic_interfaces to expose all command and state interfaces.
Features
Interfaces
Published Topics
joint_states
[sensor_msgs::msg::JointState
]:dynamic_interfaces
[control_msgs::msg::DynamicInterfaceValues
]:This addition enables better modular control of robotic grippers, paving the way for seamless integration in complex robotic systems.
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
To send us a pull request, please:
colcon test
andpre-commit run
(requires you to install pre-commit bypip3 install pre-commit
)